AdguardTeam / AdguardForiOS

The most advanced ad blocker for iOS
https://adguard.com/
GNU General Public License v3.0
1.43k stars 200 forks source link

filter lists not being updated / don't contain all rules #1974

Open DetachHead opened 2 years ago

DetachHead commented 2 years ago

Issue Details

Expected Behavior

same number of rules when re-adding the list as a custom filter list

Actual Behavior

the easylist that came with the app only has 12219 rules but when i re-add easylist as a custom filter list there are 35730 rules

Screenshots

the easylist that came with the app: it appears to have never updated since i downloaded the app months ago (22 Dec 2021) ![image](https://user-images.githubusercontent.com/57028336/163064339-4a0697be-f287-4975-8e69-f639661091c3.png) after disabling and re-enabling it it seems to have updated but it only gained a few more rules: ![image](https://user-images.githubusercontent.com/57028336/163064288-4358ab1f-4a07-4b64-80a9-e6b3d3c10330.png)
after re-adding easylist as a custom filter list from the same url: ![image](https://user-images.githubusercontent.com/57028336/163064477-c63ff2e8-3913-42e3-b8f1-13409920976d.png) ![image](https://user-images.githubusercontent.com/57028336/163064511-5683ff8b-ad1e-4d75-9151-389e9e0be42e.png)

Additional Information

my filter lists don't seem to be getting updated, and when they do, it's only adding a fraction of the rules. as a result, i've started seeing ads again on many different sites

ethan-xd commented 2 years ago

“+1 I also experiencing same issue ….”

Vitalik93 commented 2 years ago

Интересно услышать ответ разработчиков. Сам заметил что на IOS стало паршиво блокироваться реклама. Думал из за того, что пока стоит Adguard для iOS 14 без нового функционала для 15 версии, теперь уже сомневаюсь. Если такое такое количество правил отсутсвует, понятно в чем дело.

zzebrum commented 2 years ago

Hi! We use optimized filters by default. What it means and how we do so: https://kb.adguard.com/en/general/filter-rules-statistics#why-do-we-need-statistics And when you add filter manually it is not optimized. That's why there is a difference.

But there is a bug with filters update date.

zzebrum commented 2 years ago

what we can do is change this optimization algorithm a little.

Vitalik93 commented 2 years ago

Hi! We use optimized filters by default. What it means and how we do so: https://kb.adguard.com/en/general/filter-rules-statistics#why-do-we-need-statistics And when you add filter manually it is not optimized. That's why there is a difference.

But there is a bug with filters update date.

А если оптимизированные фильтры выключены, почему бы тогда все правила не применять?

zzebrum commented 2 years ago

@Vitalik93 мы же вообще эту опцию убрали из настроек

Alex-302 commented 2 years ago

Различие в количестве правил потому, что в приложении используется оптимизированный фильтр, а пользователь из первого сообщения видать импортировал полный. И подсчёт количества правил отличается от других Адгардов. "Advanced rules" вроде вообще не учитываются в счётчике.

maxikuzmin commented 2 years ago

@DetachHead issue is still relevant?

DetachHead commented 2 years ago

@maxikuzmin yes i have to keep manually opening adguard and tapping the update button otherwise the lists never get automatically updated

maxikuzmin commented 2 years ago

@DetachHead about filter updates, the problem is known, it does not repeat so often among users, and we are already solving this problem. Filters are usually refreshed within 24 to 72 hours. We recommend that you refresh the filters manually before this problem is fixed

DetachHead commented 2 years ago

@maxikuzmin thanks! is there already an open issue tracking this problem?

maxikuzmin commented 2 years ago

@DetachHead this issue will be the main