AdguardTeam / AdguardForiOS

The most advanced ad blocker for iOS
https://adguard.com/
GNU General Public License v3.0
1.43k stars 202 forks source link

The advanced rules existing in only 3rd-party filter do not work #2285

Open piquark6046 opened 8 months ago

piquark6046 commented 8 months ago

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

Issue Details

Expected Behavior

The advanced rules existing in only 3rd-party filter does work well even if AdGuard Mobile Ads filter is disabled.

Actual Behavior

The advanced rules existing in only 3rd-party filter does not work if AdGuard Mobile Ads filter is disabled.

Screenshots

https://cdn.adguard.info/sitereports/kyiji75f1v4ock8g4w00skgw84g00k8sw94bj1p9a8.jpg?nc=1 https://cdn.adguard.info/sitereports/1zk2okjvxb6s40oc000ok844sgos0gc3t0p4eeu6ec.jpg?nc=1

Additional Information

The following rules exist in List-KR filter and AdGuard Mobile Ads filter:

m.fmkorea.com#%#//scriptlet('json-prune', 'tpl apply', 'tpl.[].c', '/fmkorea.com.[A-z]{8,}.js/')
m.fmkorea.com#$?#body[class*="mac_os"] div[class="hd"] ~ *[id][class*=" "]:matches-css(padding: /5px 10px 20px/):matches-css(height: /^[0-9]{2,3}/) { remove: true; }
m.fmkorea.com#$?#header[class="hd"] ~ .fmad_wrapper ~ *[class]:matches-css(padding: /5px 10px 20px/):matches-css(height: /^[0-9]{2,3}/) { remove: true; }
m.fmkorea.com#$?#body div:is(.bd, .hd) div[style] > *[class*=" "]:matches-css(padding: /5px 10px 20px/):matches-css(height: /^[0-9]{2,3}/) { remove: true; }

To reproduce the issue, you may to use a real Korean IP address.

Related issues: https://github.com/AdguardTeam/AdguardFilters/issues/168573#issuecomment-1903975691 https://github.com/AdguardTeam/AdguardFilters/issues/168573#issuecomment-1903977416

maxikuzmin commented 7 months ago

@piquark6046 to troubleshoot this issue, we need to get the app logs.

Here's what we need you to do:

piquark6046 commented 7 months ago

Sent.

maxikuzmin commented 7 months ago

@piquark6046 strange behavior, judging from the logs the rules are applied. I was also able to reproduce this problem, Thank you, we will look into this problem

piquark6046 commented 7 months ago

Please note that the scriptlet rule was updated.

piquark6046 commented 7 months ago

Please add the following exception rules if you are about to debug:

m.fmkorea.com#@$?#body[class^="mac_os"] > div[id^="bd_"].bd:not([style]):has(> p > a[href]:matches-property(listeners.click) ~ a[href]:matches-property(listeners.click):contians(/^http/)) { remove: true; }
m.fmkorea.com#@$?#body[class="mac_os"] > .bd > div[style]:has(> .bd_mobile > p > a[href]:matches-property(listeners.click) ~ a[href]:matches-property(listeners.click):contians(/^http/)) { remove: true; }
piquark6046 commented 7 months ago

@maxikuzmin Sent a 2nd debugging log.