AdguardTeam / AdguardForiOS

The most advanced ad blocker for iOS
https://adguard.com/
GNU General Public License v3.0
1.39k stars 200 forks source link

quic server addresses with case sensitive device names aren’t being parsed correctly #2320

Closed ghost closed 2 months ago

ghost commented 2 months ago

Please answer the following questions for yourself before submitting an issue

AdGuard version

4.5.3

Environment

Ad Blocking

AdGuard Base filter, AdGuard Mobile Ads filter

Privacy

AdGuard Tracking Protection filter

Social

AdGuard Social Media filter

Annoyances

AdGuard Annoyances filter

Security

No response

Other

No response

Language-specific

No response

Advanced protection for Safari

Which DNS server do you use?

AdGuard DNS

DNS protocol

DNS-over-QUIC

Custom DNS

quic://John--Router-f8c555.dns.nextdns.io

DNS filtering

Custom DNS filter

AdGuard DNS filter

DNS implementation

AdGuard

Tunnel mode

Split-Tunnel

Low-level settings

Bootstrap server: default Fallback server: default Blocking mode, etc: default

Issue Details

Steps to reproduce:

  1. Insert quic://John--Router-f8c555.dns.nextdns.io into custom DNS servers
  2. Visit https://test.nextdns.io/
  3. Observe case sensitive device name not respected

Expected Behavior

Case sensitive server addresses are respected.

Actual Behavior

Case sensitive server addresses aren’t respected.

Screenshots

Screenshot 1 **Incorrect result when using the below DoQ server address with AdGuard for iOS** ![IMG_0582](https://github.com/AdguardTeam/AdguardForiOS/assets/149243371/7354a5c0-acca-45aa-bf63-285601e7157a) **Correct result when using a case sensitive DoQ address in AdGuard VPN** ![IMG_0583](https://github.com/AdguardTeam/AdguardForiOS/assets/149243371/2fa6572f-5d44-480d-abac-45b7e23c39c6)

Additional Information

No response

sfionov commented 2 months ago

@jslawler-gh Thank you for report, seems to be regression.

I have to say that it will stop working in AdGuard VPN too if you update, DnsLibs is updated in the upcoming version.

ghost commented 2 months ago

It seems to be working in AdGuard VPN for iOS 2.3.0, and the latest TestFlight beta (3602) still, unless you're referring to an upcoming update?

sfionov commented 2 months ago

@jslawler-gh Yes, I'm talking about upcoming version

zzebrum commented 2 months ago

Duplicate