AdguardTeam / AdguardForiOS

The most advanced ad blocker for iOS
https://adguard.com/
GNU General Public License v3.0
1.45k stars 203 forks source link

Please update the Safari filters' translations in Traditional Chinese language file. #686

Closed lancelot-moon closed 6 years ago

lancelot-moon commented 6 years ago

I don't know if it's due to the old language file left on the device since it's the same situation both with AG Pro beta v2.0.0(140) and v2.0.0(143). After installing AG Pro beta v2.0.0(140)/(143), the interface of Safari filters is Simplified Chinese translations from the beginning. After restarting AG Pro beta v2.0.0(140)/(143), the interface of Safari filters became to English. Is this a bug?

But the interface of Safari filters is still not Traditional Chinese translations. https://github.com/AdguardTeam/AdguardForiOS/issues/673#issuecomment-369172364 @aalpatkina @ameshkov You told me to not worry. That's why I always worry and often remind you.......... May I see Traditional Chinese translations for Safari filters in v2.0.1?

Thanks...

lancelot-moon commented 6 years ago

@ameshkov @IvanIin

I just tried beta v2.0.2(146). Even the situation becomes the worst.

In AG Pro beta v2.0.0(143): After installing AG Pro beta v2.0.0(143), the interface of Safari filters is Simplified Chinese translations from the beginning. After clicking "Check for updates" and restarting AG Pro beta v2.0.0(143), the interface of Safari filters became to English. Is this a bug?

In AG Pro beta v2.0.2(146): The interface of Safari filters is always Simplified Chinese translations.

@aalpatkina

And about translations for filters: I know that you've completed translations and checked all updated phrases in "Miscellaneous" project. Thank you for that. We'll update filters translations very soon. Please do not worry :)

How can I not worry? Simplified Chinese translations are still wrongly used for Safari filters in Traditional Chinese language file of beta v2.0.2(146).

Ivanlin, locale 'zh-CN' or 'zh' is Simplified Chinese for China. 'zh-TW' is Traditional Chinese for Taiwan. But you constantly wrongly use 'zh-CN' or 'zh' for Traditional Chinese.

Please, it should be not difficult to solve the issue as long as you correctly use 'zh-TW' for Safari filters in Traditional Chinese language file.

May you give the link for letting me check the content of 'zh-TW' in Safari filters?

Such like the link of AdGuard Assistant. https://github.com/AdguardTeam/AdguardAssistant/commit/aad8861a8edd721768272aa95f9d4f265f4fd818

I want to check if they're Traditional Chinese translations in locale 'zh-TW'.

ameshkov commented 6 years ago

Here it is: https://filters.adtidy.org/ios/filters_i18n.json

It is okay on the server side. @IvanIin please be careful with that.

lancelot-moon commented 6 years ago

This is the video about Safari filters in beta v2.0.2(146). https://youtu.be/NpLAfb8slzE

Simplified Chinese translations are still wrongly used for Safari filters in Traditional Chinese language file. I'll check again in the next beta version.

Here it is: https://filters.adtidy.org/ios/filters_i18n.json

Yes, after roughly checking, Traditional Chinese translations in locale 'zh-TW' are ok.

Sorry to bother you. Please go to sleep early. Good night, AdGuard team.

I announced the release of AG Pro v2.0.0 on PTT BBS. https://www.ptt.cc/bbs/iOS/M.1520380874.A.F3F.html Congratulations to AdGuard team. AdGuard Pro ranks No.1 in Utilities on Taiwan iTunes App Store. The total rank is No.4.

Screenshots: ![image](https://i.imgur.com/GOvgolW.jpg) ![image](https://i.imgur.com/bunKIMA.jpg)

B/R
lancelot-moon commented 6 years ago

@IvanIin

You never solve the translation issue for Safari filters. However, you let v2.0.2(146) released on App Store................................................................. Why? They're Simplified Chinese translations.

Screenshot: ![image](https://i.imgur.com/Ug5PQsz.png)

Please only use locale 'zh-TW' for Traditional Chinese language file, not 'zh-CN' or 'zh'. I don't want to say that the hotfix was wasted, but it's imperfect. So will you soon do updates again??? I am really defeated.
ameshkov commented 6 years ago

We will soon resolve it, don't worry :)

The hotfix was required to solve the issue with the disappearing subscriptions.

lancelot-moon commented 6 years ago

Forgive for my unclear meaning. I meant that the chance of early applying Traditional Chinese translations for filters in that hotfix was wasted, which is a pity. Eh, I found AdGuard team recently did some updates for filters' strings on oneskyapp. Maybe that's why it's delayed.

Simplified Chinese is only used by Chinese people. Taiwanese people use Traditional Chinese.

Because Simplified Chinese translations in Traditional Chinese language file tormented AdGuard's Taiwanese users for many years, I am specially concerned with the issue.

Sorry to bother AdGuard team.

ameshkov commented 6 years ago

I meant that the chance of early applying Traditional Chinese translations for filters in that hotfix was wasted, which is a pity.

The main issue here is not oneskyapp, but the fact that AG for iOS fails to use the proper language.

It should use the following logic:

  1. Look for the translation with the full language code (pt_BR or zh_TW for instance)
  2. If not found, strip the country code and look for the translation with a short language code (pt or zh)
  3. If nothing found, use en

The problem is that it fails to find the proper translation on step 1, and it should be fixed on the app side.

lancelot-moon commented 6 years ago

How about the following logic: Don't consider zh.

  1. Look for the translation with the full language code (pt_BR or zh_TW for instance)
  2. If not found, strip the country code and look for the translation with a short language code (pt or en)
  3. If nothing found, use en

Only Traditional Chinese and English are acceptable for Taiwanese people. Such like that Simplified Chinese isn't used by Russian people. Simplified Chinese is also not used by Taiwanese people.

lancelot-moon commented 6 years ago

Have you solve the issue of Traditional Chinese translations for filters in the next beta version? If not, please reopen the issue. Otherwise, @IvanIin will always ignore the issue, such like v2.0.0 and v2.0.2. Originally, this should be solved in v2.0.0 and v2.0.2, but it was just a bounced cheque...

ameshkov commented 6 years ago

@lancelot-moon could you please check it in the regular AdGuard for iOS (not Pro)?

The issue should've been fixed there (so the fix will arrive in the next Pro update as well)

lancelot-moon commented 6 years ago

I went to install free AdGuard for iOS v2.0.2(92). Yes, you have solved it!!! Thank AdGuard team very much!!!

They're Traditional Chinese interface. :D Hope that Traditional Chinese translations for filters in other platforms (Android, Windows, macOS, content blocker and browser extensions) can be also solved. Thanks for your hard working again!

Screenshots: ![image](https://i.imgur.com/Lk31ZHd.png) ![image](https://i.imgur.com/UKS3GMI.png)