AdguardTeam / AdguardForiOS

The most advanced ad blocker for iOS
https://adguard.com/
GNU General Public License v3.0
1.45k stars 203 forks source link

DNS filtering / privacy module disabled after some time #771

Closed kevandoyle2 closed 6 years ago

kevandoyle2 commented 6 years ago

This has been occurring in all 3 modes, including the new mode of full-tunnel (with the VPN icon, a feature that I assume is new as of the update yesterday). When I say disabled, I do not mean it toggles itself off, rather, it continues to be toggled on but it will not filter DNS traffic and sometimes stop internet connections all together.

Steps to reproduce

  1. Enable the privacy module
  2. Close the app and continue to use device as normal, opening apps that run ads and using them
  3. After using an app for a few seconds, close it. Open the Adguard app again and open the DNS request log. Close request log and repeat 2 and 3. If nothing happens, try switching between wifi and cellular networks. Another way to induce this issue is by switching between the two full-tunnel modes while the module is enabled.
  4. Eventually, device traffic will stop being filtered, even though the privacy module remains enabled, allowing ads to be displayed.

I have not tried this with split-tunnel, only with the new and old version of full-tunnel. When this bug happens, I have found turning the module off and on again will usually fix it, but in some cases I have had to restart my entire device to get it working again. It should be able to remain connected continuously, even when switching between cellular and wifi networks, and between modes.

Customer ID

1860764

Your environment

ameshkov commented 6 years ago

Good providing the ‘restart when network changes’ switch is off but as soon as you turn it on everything is blocked again.

What matters is that the default switch value is now "off". I doubt we can do anything with how it behaves when it's "on".

Marco224 commented 6 years ago

In my case nothing has changed, it certainly happens much less than when the switch is on, but the problem is not solved. Ads that are blocked in the log continue to appear.

Marco224 commented 6 years ago

However now when the switch is off now if imposed full-tunnel with VPN icon at the time of network change the AdGuard vpn no longer starts. Here is the video: https://ufile.io/2gmdd

zebrum commented 6 years ago

Hi @Marco224 ! Why is it 'ipad' on your video in top-left corner instead of the mobile carrier name when wi-fi is turned off?

Also can you record a video of what is happening on settings->general->VPN screen when VPN can't start?

Marco224 commented 6 years ago

The iPad inscription appears as I'm testing the app on a 5th generation iPad. It's much easier to make the problem appear by turning Wi-Fi on and off because the problem always occurs even when you turn off the "tunnel restart" switch. During the change between Wi-Fi and mobile data deactivating the "tunnel restart" the problem appears 1 time out of 5 for this is more difficult to make a video or otherwise for me is negligible. If you want I can make a video also in that case.

WiFi on-off-on Full tunnel with vpn icon (log and vpn setting) Here is the video on iPad 2017 iOS 11.4: https://ufile.io/3y2e9 Here is the video on iPhone 6s iOS 11.4: https://ufile.io/ufe4a

I would add that when (always in full-tunnel with vpn icon) the vpn icon does not appear after turning off and on Wi-Fi, not even the block of content on safari works more ...

zebrum commented 6 years ago

@Marco224 I would appreciate if you catch the moment on video when VPN won't connect after switching from wi-fi to mobile. (settings->general->VPN screen is enough). And logs too apple at adguard.com

Marco224 commented 6 years ago

I'm not sure what you mean I should do... what should I do on adguard.com? Sorry but my English is very bad... the problem only happens if you load any content that requires an internet connection while you change the connection, so this (the split screen on iPad) is the only way I have to show the settings on the vpn while loading a content. Unfortunately I don't have an iPad with mobile connection and I can't test the WiFi- Mobile data- WiFi step showing the settings on the vpn, and the split screen is not available on iPhone. I hope I have not misunderstood what you meant. Here is the video: https://ufile.io/1mmzx

zebrum commented 6 years ago

@Marco224 ok, I need you to reproduce the problem when filtering stops after switching from wi-fi to mobile and send logs to us, specify the exact time when issue happened.

Marco224 commented 6 years ago

I have sent the log, it happened at 01:12 during the switch WiFi-mobile on iPhone. User ID: 1148487

If you want I can post the screen ad 1:12 with the ads. Making a video by capturing exactly when it happens is impossible (in the case of WiFi - mobile data - WiFi), since it happens randomly using the phone. I am no longer able to reproduce the problem by myself (after deactivating the "tunnel restart"). Ads appear during a random connection change, so I do not attach a video. :)

In this case I watched some videos on YouTube and opened Newsify to read something before going to sleep...

veronikasav commented 6 years ago

User ID 1148487 Archive.zip

Marco224 commented 6 years ago

Hi! I sent yet another log where a different case occurred, in this case the vpn icon has not disappeared but the ads have appeared anyway while I’m on cellular data... in the log the ads are displayed in yellow and no longer in red (AppLovin, Amazon-adsystem...).🧐

As always I have the screen if you need

It happened at 8:46

ghost commented 6 years ago

Version 2.1.1 with ‚Tunnel restart‘ enabled fixes the issue for me. Full Tunnel Mode works fine now, network changes are not a problem anymore.

Thanks!

Marco224 commented 6 years ago

Hi guys! I'm back here :) I quickly tested the new build (166) and, in my case, I didn't notice any differences when the "Restart when network changes" switch is off: the problem is still there. But... I tried to reactivate the switch "Restart when network changes" it seems that the problem disappears both on iPad (WiFi on- WiFi off- WiFi on) and on iPhone (WiFi- cellular- WiFi). Ads that are red in the log are correctly blocked even during connection changes. 🤔 It's strange, but in my case, for now it simply works perfectly when the switch is on.

In any case, I do not want to rush to conclude; I will update you if I still have any problems. Good job!

Marco224 commented 6 years ago

Nothing to do, there was only a day after the update that seemed completely disappeared, now the problem always comes up again even with "restart when network changes" activated. In exactly the same way as before. I don't know how @rafuse managed to solve it.

zebrum commented 6 years ago

@Marco224 there is one more guess about wi-fi assist option enabled. Can you try to disable it?

Marco224 commented 6 years ago

I will try with the option disabled. I already tested AdGuard 2.1.1 with WiFi assistant disabled and it didn't change anything. I will let you know, although it does not seem a solution to the problem deactivate a useful system function

Marco224 commented 6 years ago

I confirm that nothing changes, the only thing that changes is the distance from the wifi where the problem occurs, where the connection speed is obviously slower because it insists on using the wifi connection too weak because of the distance

ameshkov commented 6 years ago

Guys, bad news: https://adguard.com/en/blog/adguard-pro-discontinued/

drlivesey commented 6 years ago

@ameshkov It is quite possible that renaming the app will help. Let's call it DnsGuard ;) This way it will totally "use APIs and frameworks for their intended purposes..." You developed a very nice and unique product! I hope you will be able to save it.

Marco224 commented 6 years ago

I don't know if this can help, but if you think that there are so many apps on the Appstore that allow you to clear the iphone cache while not mentioning it at all in the description and preview of the app in the store. Despite this is not allowed by the policies of the store continue to be updated (because they do not mention it in descriptions or previews) and have always existed. I know that this isn't probably your way of working... but in my opinion this is the only solution, rather than limiting such a well-made app.

ameshkov commented 6 years ago

Too risky, we can easily lose the dev account if we try something like this.