AdguardTeam / BrowserAssistant

AdGuard Browser Assistant
https://adguard.com/en/adguard-assistant/overview.html
GNU Lesser General Public License v3.0
35 stars 5 forks source link

Toggling the rule `@@||example.org^$important,document` doesn't properly update the Browser Assistant icon #105

Open contribucious opened 1 year ago

contribucious commented 1 year ago

:wave: Hello,

Please find below two different but related problems. Ensure a clean state between the two.

Note: Issue opened in CoreLibs instead of Browser Assistant, based on my previous ones here and there (which had been moved to CoreLibs).

Thanks in advance! :v:  


:computer: Environment

AdGuard Browser Assistant: Beta 1.3.32 (on Firefox 111.0.1) AdGuard: 7.13 nightly 5 (build 4224, CL 1.11.69) Windows: 10 Pro 22H2 (OS Build 19045.2728)

contribucious commented 1 year ago

:mag: Problem 1 — STR

  1. Add this user rule into Filter Editor:
    @@||example.org^$important,document
  2. Go to https://example.org/  ›››  BA icon is gray. ✔️
  3. Remove (or disable) this rule from the filter editor.
  4. Wait a bit and observe that the BA icon remains gray, instead of switching to green. ✖️ Even after a click on the icon, which shows the popup with the correct reality (i.e. the updated state).
:gear: Workaround

Click on another tab you have (or create one with + in your browser) and go back to your tab. Icon is now correctly green.

contribucious commented 1 year ago

:mag: Problem 2 — STR

  1. Add this user rule into Filter Editor:
    @@||example.org^$important,document
  2. Go to https://example.org/  ›››  BA icon is gray. ✔️
  3. Disable this rule from the filter editor.
    • Wait a bit and observe that the BA icon remains gray, instead of switching to green. ✖️
  4. But now, re-enable this allowlisting rule from the filter editor.
    • Observe that the BA icon instantly turns green (expected behavior: gray). ✖️
  5. And now, wait a bit and re-disable it again.
    • Observe that the BA icon instantly turns gray (expected behavior: green). ✖️
:arrow_right_hook: And in fact, from now on, at each enabling/disabling, the change observed will always be the opposite of the one expected.

  Remarks:

ameshkov commented 1 year ago

Surprisingly enough, this one should be opened in the assistant repo :)