search

AdguardTeam / BrowserAssistant

AdGuard Browser Assistant
https://adguard.com/en/adguard-assistant/overview.html
GNU Lesser General Public License v3.0
35 stars 5 forks source link

Browser Assistant icon is still gray after the 30 sec. of `Do not filter for 30 seconds` #79

Closed contribucious closed 1 year ago

contribucious commented 1 year ago

(:wave:) Steps to reproduce

  1. Go to https://example.org.
  2. Open the Browser Assistant popup and click on Do not filter for 30 seconds. :arrow_right_hook: The extension icon changes correctly from green to gray.
  3. Wait the 30 seconds.

Expected behavior

The icon turns green again.

Actual behavior

The icon remains gray.

:eyes: Unless … you perform a specific action (such as switching to another tab and then returning to your tab, event that will refresh the icon correctly — same case for the refresh of any open tab in a different window you may have).

:movie_camera: Video https://user-images.githubusercontent.com/4764956/184254460-8120cb51-9dc5-4781-a94e-6e6289ec83b6.mp4

   

:thought_balloon: Reflection

Click to read …   I did consider that this could have been done on purpose _— regarding this intermediate state, i.e. page displayed unfiltered but new XHR & co requests now filtered —_, but after testing and reflection, I don't think so. Notably for reasons of consistency, among others the fact: - that the `Enabled on this website` switch is flipped to `ON` again in the popup itself and also - that for example, if a user in a dual monitor configuration or on a ultra wide monitor refreshes any tab he might have on his second monitor / other browser window, the AG icon of the tab `example.org` will be correctly refreshed in this case, so … should be like so in all cases or none IMHO.

 

Thank you in advance. :thumbsup:

Environment Browser Assistant 1.3.13 — Reproducible on both Firefox 103.0.2 and Edge 104.0.1293.54 AdGuard 7.10.2 on Windows 10 Pro 21H2 (OS Build 19044.1865)