Support `GM_registerMenuCommand` and `GM_unregisterMenuCommand`

piquark6046 commented 1 year ago

Description

Currently, AdGuard does not support GM_registerMenuCommand and GM_unregisterMenuCommand that is required when an userscript developer wants to add its configuration feature, etc.

Suggestion

Option button I think that placing the button here is better.

Screenshot
![Screenshot from 2022-11-25 13-37-30](https://user-images.githubusercontent.com/98787049/203997412-ad7255f9-fca3-4477-ba6f-568803579641.png)

The onClick event must be executed only when any matched webpage is opened.

Reference

https://violentmonkey.github.io/api/gm/#gm_registermenucommand

ngorskikh commented 1 year ago

I don't think we should give userscript developers an ability to execute code inside our applications. The applications don't even have a javascript engine to run it, anyway. @ameshkov discuss? AFAIK userscripts that want to have persistent configuration usually implement some sort of a menu on the page that they are injected into, and store/load the values with GM_setValue/GM_getValue.

ameshkov commented 1 year ago

Agreed. but I think we can implement this entirely in the page context without involving CoreLibs.

bropines commented 2 months ago

As far as I understand, it’s still hanging in todo?

AdguardTeam / CoreLibs