AdguardTeam / CoreLibs

Core Adguard libraries
https://adguard.com/
Apache License 2.0
39 stars 7 forks source link

Failed to upload file to my own github repository #1884

Open robifr opened 9 months ago

robifr commented 9 months ago

Please answer the following questions for yourself before submitting an issue.

AdGuard version

4.4

Environment

- OS: android 13
- Device: redmi note 11

Root access

What filters do you have enabled?

AdGuard Base filter, AdGuard Mobile Ads filter, AdGuard Tracking Protection filter, AdGuard Social Media filter, AdGuard Cookie Notices filter, AdGuard Popups filter, AdGuard Mobile App Banners filter, AdGuard Widgets filter, AdGuard Other Annoyances filter

What Stealth Mode options do you have enabled?

standard tracking protection

How to reproduce

Prerequisites

Steps

  1. on your own github repository, click "upload file".
  2. upload any big sized file (10-25MB) via "choose your file" button.
  3. as soon as the file is being processed with "uploading 1 of 1 file" message, immediately re-click "choose your file" button again.

Expected Behavior

file uploaded successfully

Actual Behavior

error saying "Something went really wrong, and we can't process that file."

Additional info

If the error is not shown for unknown reason, restart protection in AdGuard, reload GitHub page and just retry again all the steps.

Screenshots

Screenshot 1: ![Screenshot_2023-12-25-01-09-35-841_com android chrome-edit](https://github.com/AdguardTeam/AdguardForAndroid/assets/78811448/cb247ba9-3d1d-45c7-b868-6527c69a0419)

Additional Information

this behavior sometimes occurred for unknown reason. i'm certain that it's a possible bug from adguard, because there's no kind of failure from github when adguard was disabled. refreshing the web and switching connections also made no difference.

robifr commented 9 months ago

looking from the statistics of com.android.chrome itself, normally a successful upload will return a request with status "processed". look carefully at the timestamp.

IMG_20231225_132222

IMG_20231225_132020

IMG_20231225_131931


however, a failed upload will only return its initial request. Screenshot_2023-12-25-13-25-28-645_com adguard android-edit

IMG_20231225_132713

Versty commented 8 months ago

@robifr Hi! We have tried to reproduce this issue on our side, but to no avail. Therefore, we would like to take at look at the logs from your device. Please follow the steps below.

  1. Enable debug logging: Settings -> General -> Advanced -> Logging level -> Debug

  2. Reproduce the issue, then remember the exact time when it happened

  3. Collect logs: Settings -> General -> Advanced -> Export logs and system info

  4. Send this file to devteam@adguard.com:

    • mention the 5128 number in the subject
    • specify the exact time when the issue occurred
Versty commented 8 months ago

@robifr Have you sent the logs?

robifr commented 8 months ago

@Versty i have actually sent since the day you requested. sorry i forgot to inform

Versty commented 7 months ago

@robifr Please update the application to the latest nightly version and check for the filters update. Does the upload to GitHub still display the error?

robifr commented 7 months ago

@Versty unfortunately, got an issue AdguardTeam/AdguardForAndroid#5236

robifr commented 7 months ago

@Versty the bug still exists in the latest version.

investigating further, this bug doesn't exist on firefox. for chrome, when "choose your file" button is clicked, a bottom dialog will shown to pick either "camera" or "media picker". however this behavior doesn't exists on firefox, firefox will defaults open "media picker", which leads me to assume this is what possibly cause the bug to happen. Screenshot_2024-03-08-14-21-42-272_android-edit

also, disabling entire protection (ad blocking, tracking protection, annoyance blocking, dns protection, firewall, and browsing security) have no avail. i doubt this is caused by the filter.

a step-by-step of how i reproduce the bug still same. for more precise one, please watch the attached video i have sent to you a month ago.

zzebrum commented 5 months ago

@robifr

Files that you add to a repository via a browser are limited to 25 MiB per file. You can add larger files, up to 100 MiB each, via the command line. For more information, see "Adding a file to a repository using the command line." To add files larger than 100 MiB, you must use Git Large File Storage. For more information, see "About large files on GitHub."

source

Please specify the file size you were trying to upload?

robifr commented 5 months ago

@zzebrum the one with 25mb. it's just to make the bug reproduction easier. because the bug only occurs during the loading process.

Versty commented 4 months ago

@robifr Managed to reproduce this issue on our device with cellular network, file size 13MB. With AdGuard enabled, GitHub struggles to upload a file if during the uploading process the choose your files option is used again.