search

AdguardTeam / CoreLibs

Core Adguard libraries
https://adguard.com/
Apache License 2.0
40 stars 7 forks source link

You must strip `*.` from CN before matching against the url filter #259

Closed ameshkov closed 6 years ago

ameshkov commented 6 years ago
  1. *.appmetrica.webvisor.com is not blocked while it must be.
  2. It is confusing to see such value in the log

What I suggest:

  1. Fixing the blocking functionality
  2. I suggest placing CN in a new field: RequestProcessedEvent.serverCommonName
sfionov commented 6 years ago

Still persists in RequestProcessedEvent if HTTPS filtering is enabled

sfionov commented 6 years ago

core/pull-requests/476