search

AdguardTeam / DnsLibs

DNS filtering library that's used in AdGuard products
https://adguard.com/
Apache License 2.0
99 stars 20 forks source link

Allow specifying tcp-only and udp-only DNS upstreams #208

Closed ameshkov closed 8 months ago

ameshkov commented 1 year ago

For instance tcp://8.8.8.8 or udp://8.8.8.8

DandelionSprout commented 1 year ago

From how I understand it, simply 8.8.8.8 would already be UDP-only, unless there's some backend stuff I'm unaware of.

tcp:// seems to work in AdGuard for Windows. It works in AdGuard Home. And it worked in AdGuard for Android 3.x, making this situation a feature regression.

The original report being closed with the reasoning of "Just use UDP lol" made me stunned, baffled, and speechless.

ameshkov commented 1 year ago

simply 8.8.8.8 would already be UDP-only

Not really, 8.8.8.8 is both UDP and TCP, i.e. when the response is truncated it switches to TCP.

ameshkov commented 1 year ago

Relevant task: https://github.com/AdguardTeam/DnsLibs/issues/209

We need to change all products (AG for Win/macOS/iOS/Android) so that they rely on DnsLibs for this functionality.