Make ublock version of AdGuard filters compatible with Adblock/Adblock Plus

AdguardTeam / FiltersCompiler

A tool that compiles & validates filters

GNU Lesser General Public License v3.0

52 stars 12 forks source link

Closed ameshkov closed 6 years ago

ameshkov commented 6 years ago

It says that it's not a valid filter as it misses the necessary [Adblock Plus 2.0] (and maybe smth else): https://uploads.adguard.com/up04_68i9v_Adblock_Plus_Options.png

Let's make it compatible.

Mizzick commented 6 years ago

ublock will then need to remove this header, cause in ADB they exclude it before checksum calculation.

ameshkov commented 6 years ago

@Mizzick I don't fully understand what are you talking about:)

Mizzick commented 6 years ago

I mean if ublock verifies the checksum, it is neccessary to remove this header line before calculation file content checksum.

ameshkov commented 6 years ago

It must not work that way on our side, the checksum should be calculated from the full file content.

Mizzick commented 6 years ago

But we don't use ublock platform builds. And otherwise it will not be supported by Adblock