search

AdguardTeam / FiltersCompiler

A tool that compiles & validates filters
GNU Lesser General Public License v3.0
52 stars 12 forks source link

Choose platforms for which the filter list is compiled #101

Closed ameshkov closed 3 years ago

ameshkov commented 3 years ago

There's one thing that bothers me: $removeparam is not supported by the browser extension (it'll be soon, but not yet) and by Safari/iOS (never will be).

We should be able to control this on the server-side and choose for which platforms the lists are compiled.

A task for https://github.com/AdguardTeam/FiltersCompiler

Originally posted by @ameshkov in https://github.com/AdguardTeam/FiltersRegistry/issues/401#issuecomment-793008628

ameshkov commented 3 years ago

There's one important thing that we missed.

We should continue building platform-version of the filter list, the only thing that we shouldn't do for "excluded" lists -- we should not include it into filters.json file for this platform.

For instance, we might want to remove a list for some of the platforms, but we don't want to break anything for those users who already enabled it. So that's what we should do - get rid of it in filters.json, but keep the txt file intact.