AdguardTeam / FiltersCompiler

A tool that compiles & validates filters
GNU Lesser General Public License v3.0
52 stars 12 forks source link

Filters compiler fails to transform the `:style` rules properly #14

Closed ameshkov closed 6 years ago

ameshkov commented 6 years ago

See the details here: https://github.com/AdguardTeam/ContentBlocker/issues/107#issuecomment-372024790

Problematic rules:

apkmirror.com##body .google-ad-leaderboard-smaller:style(position: absolute!important; left: -4000px!important; display:block!important;)
apkmirror.com##body .google-ad-square-sidebar:style(position: absolute!important; left: -4000px!important; display:block!important;)

Both rules should've been transformed into the #$# syntax, but they didn't:

apkmirror.com#$#body .google-ad-leaderboard-smaller { position: absolute!important; left: -4000px!important; display:block!important; }
apkmirror.com#$#body .google-ad-square-sidebar { position: absolute!important; left: -4000px!important; display:block!important; }
ameshkov commented 6 years ago

@Mizzick smth is still not okay: https://github.com/AdguardTeam/ContentBlocker/issues/107#issuecomment-381290721

Mizzick commented 6 years ago

the rules are in place: https://filters.adtidy.org/extension/chromium/filters/2.txt Most probably it was filtered for content-blocker.

Mizzick commented 6 years ago

Indeed, we omit "#%#", "#@%#", "#$#", "#@$#", rules.