search

AdguardTeam / FiltersCompiler

A tool that compiles & validates filters
GNU Lesser General Public License v3.0
52 stars 12 forks source link

Remove adblock agents #153

Closed scripthunter7 closed 2 years ago

scripthunter7 commented 2 years ago

The build inserts an unnecessary ! before the adblock agent: https://github.com/AdguardTeam/FiltersRegistry/blob/master/filters/ThirdParty/filter_203_hufilter/filter.txt

I guess the tool doesn't know this adblock agent, but it removes [Adblock Plus 2.0] properly, for example

Possible agents:

See GitHub Linguist agent heuristics: https://github.com/github/linguist/blob/bf853f1c663903e3ee35935189760191f1c45e1c/lib/linguist/heuristics.yml#L681-L700

scripthunter7 commented 2 years ago

Update:

! is caused by template design: https://github.com/AdguardTeam/FiltersRegistry/blob/master/filters/ThirdParty/filter_203_hufilter/template.txt

The only issue is that the adblock agent is not deleted, but the ! not related to this. I submitted a PR.

tvinzz commented 2 years ago

merged