search

AdguardTeam / FiltersCompiler

A tool that compiles & validates filters
GNU Lesser General Public License v3.0
52 stars 12 forks source link

removeparam value that starts with `/` parsed as invalid regexp #160

Open Alex-302 opened 1 year ago

Alex-302 commented 1 year ago

[20:14:55][ERROR]:Invalid rule in AdGuard URL Tracking filter: ||hktvmall.com/yuicombo?$script,removeparam=/_ui/shared/common/js/util/jquery.analytics-utils.js

slavaleleka commented 1 year ago

error text: Error: "Invalid flags supplied to RegExp constructor 'shared/common/js/utilg'" in the rule: "||hktvmall.com/yuicombo?$script,removeparam=/_ui/shared\/common\/js\/util/jquery.analytics-utils.js/"

should be improved: Error: Invalid $removeparam value ...

krystian3w commented 1 year ago

@yuki2718 @otksm

Yuki2718 commented 1 year ago

I thought Alex reworte the rules.

Alex-302 commented 1 year ago

@Yuki2718

Details ![image](https://user-images.githubusercontent.com/8361299/207811109-05c50beb-93f3-476e-bfca-68d32468b526.png)
Yuki2718 commented 1 year ago

So now okay, not?

Alex-302 commented 1 year ago

Yes. But error message should be improved.