search

AdguardTeam / FiltersCompiler

A tool that compiles & validates filters
GNU Lesser General Public License v3.0
52 stars 12 forks source link

Convert @media rules into :matches-media() for uBO version #175

Closed Yuki2718 closed 7 months ago

Yuki2718 commented 1 year ago

Currently rules with @ media are just skipped for uBO version of lists, but now uBO supports this as :matches-media(): https://github.com/gorhill/uBlock/wiki/Procedural-cosmetic-filters#subjectmatches-mediaarg So please convert those rules although the from is very different from AG.

Yuki2718 commented 11 months ago

I think it's already fixed

Yuki2718 commented 11 months ago

After https://github.com/AdguardTeam/AdguardFilters/commit/dd9e5d6c1a26b2e86ed841a7629f5398b31197d4 and https://github.com/AdguardTeam/AdguardFilters/commit/377d56eba35254e58592606f8c074f4d8f3a93b2 jikayosha.jp#$#@media (min-width: 641px) { .wym-v2022__header.is-scroll-up ~ .wym-v2022__footer-fixed.is-pc-bottom { bottom: 0 !important; } } or jikayosha.jp#$#.wym-v2022__header.is-scroll-up ~ .wym-v2022__footer-fixed.is-pc-bottom:matches-media((min-width: 641px)) { bottom: 0 !important; } is no more included in uBO version of AdGuard Japanese. They both were included and thus were redundant before the commit. Bug in FiltersCompiler?