search

AdguardTeam / FiltersCompiler

A tool that compiles & validates filters
GNU Lesser General Public License v3.0
52 stars 12 forks source link

Failed to build filters #31

Closed maximtop closed 6 years ago

maximtop commented 6 years ago

@Alex-302 commented on Fri Nov 16 2018

Travis failed to build filters, because of hufilter rules:

prohardver.hu##p:-abp-contains(Amikor a szoftver illeszkedik a meglévő üzleti folyamatokhoz.)
prohardver.hu##div[id="center"] > div:-abp-has(div):-abp-has(a):-abp-has(Mostantól bármely bank ügyfelének elérhető a mobilfizetés élménye.)

Excluded https://github.com/AdguardTeam/FiltersRegistry/pull/123

maximtop commented 6 years ago

I did some investigation and found that Travis builds failed when we called ExtendedCss.query on the long string with . in the end. p:-abp-contains(Amikor a szoftver illeszkedik a meglévő üzleti folyamatokhoz.) Anyway, this call didn't break tests on the ExtededCss. So I've decided that jsdom can cause this. Updating jsdom fixed issue.