AdguardTeam / FiltersCompiler

A tool that compiles & validates filters
GNU Lesser General Public License v3.0
52 stars 12 forks source link

Convert ##^script:has-text to $$script[tag-containts] #60

Closed ameshkov closed 4 years ago

ameshkov commented 4 years ago

See how this task was implemented in the browser extension: https://github.com/AdguardTeam/AdguardBrowserExtension/issues/1452

We should do this on the server-side to avoid messing with the old AdGuard versions that don't understand this type of rules automatically.

Please note, that if the ##^ cannot be converted automatically for some reasons, it should be considered invalid.

krystian3w commented 4 years ago

no typo?

$$script[tag-containts] vs https://kb.adguard.com/en/general/how-to-create-your-own-ad-filters#tag-content-attribute

ameshkov commented 4 years ago

Uh, that's my bad! We'll fix it asap

krystian3w commented 4 years ago

https://github.com/AdguardTeam/FiltersRegistry/issues/280