search

AdguardTeam / HostlistsRegistry

Known hosts blocklists that are made available to the users of AdGuard products
https://adguard-dns.io/
GNU General Public License v3.0
213 stars 74 forks source link

Replace @@ with denyallow #401

Closed KnightmareVIIVIIXC closed 10 months ago

KnightmareVIIVIIXC commented 10 months ago

Change @@||discord.gift to modifier: ||discord*.gift^$denyallow=discord.gift. Tested and working.

hagezi commented 10 months ago

The lists are created automatically based on the source. Your changes will therefore be overwritten with the next update.

However, Denyallow is not currently supported by the hostlist compiler. Rules with Denyallow are not adopted.

This is the reason why @DandelionSprout has solved this via @@||.

DandelionSprout commented 10 months ago

1) The OP is probably in the wrong repo. 2) https://github.com/AdguardTeam/HostlistsRegistry/blob/main/filters/security/filter_12_DandelionSproutsAntiMalwareList/filter.txt shows it became supported 2 or 3 weeks ago. 3) I don't currently see a problem with @@||discord.gift^. Even in the event that someone really doesn't like the Discord platform, ||discord.gift^$important in custom entries would've sufficed. I suppose I can doublecheck to compare with AdGuard Home's service blocking, but that'd be a fringe scenario in my eyes personally.

hagezi commented 10 months ago

2) https://github.com/AdguardTeam/HostlistsRegistry/blob/main/filters/security/filter_12_DandelionSproutsAntiMalwareList/filter.txt shows it became supported 2 or 3 weeks ago.

Thanks for pointing that out, I had overlooked it.

KnightmareVIIVIIXC commented 10 months ago

My way of thinking is to safe guard against potential future threats. For example, if sub.discord.gift becomes malicious and the ||discord*.gift^$denyallow=discord.gift rule is used, then the user will be safe; if you leave the @@||discord.gift^ rule, then the dangerous sub.discord.gift will be processed even if the user adds the rule ||sub.discord.gift^ to block the domain. Might as well take advantage of the modifiers available in the adblock syntax. https://i.postimg.cc/PrN6dYzW/Screenshot-20231202-112706-2.png

KnightmareVIIVIIXC commented 10 months ago

https://github.com/DandelionSprout/adfilt/pull/969#issuecomment-1837303907

ameshkov commented 10 months ago

However, Denyallow is not currently supported by the hostlist compiler. Rules with Denyallow are not adopted.

Why, it is supported: https://github.com/AdguardTeam/HostlistCompiler/blob/f8559b02ee1730b6493e5aa57a9551222a6beda5/src/transformations/validate.js#L15

DandelionSprout commented 10 months ago

Support was only added a few weeks ago, so I suppose the word hasn't spread widely out yet.