search

AdguardTeam / PopupBlocker

Popup blocking userscript
GNU Lesser General Public License v3.0
337 stars 31 forks source link

Exclusion can be created incorrectly #108

Closed vozersky closed 6 years ago

vozersky commented 6 years ago

Still works though.

STR:

  1. Install PopupBlocker to Adguard for Win
  2. Open http://testcases.adguard.com/PopupBlocker/test-popup-blocker.html
  3. Reproduce any popup on the page
  4. Click on "always allow %urlname%" (allow popups leading to evilsite.com)
  5. Before the notification disappears open it and perform step "4" two more times.

Expected result: {"whitelist":"[LString;evilsite.com"}

Actual result: {"whitelist":"[LString;evilsite.com,evilsite.com,evilsite.com"}

Video: https://uploads.adguard.com/up05_wc1mj.mp4

theseanl commented 6 years ago

This should be fixed with 2.5.1.

theseanl commented 6 years ago

For example, when a page testcases.adguard.com/PopupBlocker/test-popup-blocker.html is opened in a 2 separate tabs and whitelisting is done on both tab within a short time, it should not create a duplicate entry in the userscript storage.

karina-archazh commented 6 years ago

Checked, no duplicates.