AdguardTeam / PopupBlocker

Popup blocking userscript
GNU Lesser General Public License v3.0
337 stars 31 forks source link

AG PB is Simplified Chinese interface when choosing browser default in the Tampermonkey's language setting. #167

Closed lancelot-moon closed 4 years ago

lancelot-moon commented 5 years ago

@ameshkov @northis

Before, I didn't check the interface of AG popup blocker... Today, I install it in Tampermonkey. Even if you compile zh-TW locale file, you still wrongly use Simplified Chinese (zh or zh-CN) for Traditional Chinese (zh-TW) interface.

Screenshot: ![image](https://i.imgur.com/XNWBp6c.png)

// ==UserScript== // @name AdGuard Popup Blocker Simplified Chinese (简体中文) (Usually it should be zh-CN, but you used zh.) // @name:zh AdGuard 弹窗拦截器 Traditional Chinese (繁體中文 or 正體中文) (zh-TW) // @name:zh-TW AdGuard 彈出式視窗封鎖器 Please fix it. I ever suggested to modify zh to zh-CN, otherwise your developers will feel confused. https://github.com/AdguardTeam/PopupBlocker/issues/159 Well, you only use my Traditional Chinese translation for its title on greasyfork.org. https://greasyfork.org/zh-TW/scripts/33396-adguard-popup-blocker
lancelot-moon commented 5 years ago

@northis May you also check the language interface for Web of Trust when the system language is Traditional Chinese (zh-TW)?

// ==UserScript== // @name Web of Trust // @description Check out any website for reputation and safety information based on users’ experience.

Simplified Chinese (zh-CN): // @description:zh 在用户体验基础上浏览任何名誉网站和安全信息。

Traditional Chinese (zh-TW): // @description:zh-TW 根據用戶的體驗檢查任何的網站在信譽和安全資訊方面。

I suggest to modify zh to zh-CN for Simplified Chinese. Maybe it's the same mistake.

In the past, AG Assistant had the same bug (use Simplified Chinese for Traditional Chinese interface). But @maximtop had fixed it. Maybe he can help...

maximtop ever used my PC for debugging via TeamViewer. If you have the need, some AG developers know my telegram account. You can find me on telegram.

northis commented 5 years ago

You use Tampermonkey to test PB. We will check it, but if you try PB & WOT with AG (not Tampermonkey), they will use the same language as AG and traditional chinese is supported there.

BTW, try to use the latest version of PB & WOT. north2awnu

lancelot-moon commented 5 years ago

Here, it's still PB v2.5.11. https://greasyfork.org/zh-TW/scripts/33396-adguard-popup-blocker

I went to AG GitHub for PB v2.5.12. In the Tampermonkey's language setting, if I choose "Browser Default", PB v2.5.12 will be Simplified Chinese.

Screenshots: ![image](https://i.imgur.com/AGzolKS.png) ![image](https://i.imgur.com/A8rQFtP.png)

After I choose "Chinese (Traditional)" in the Tampermonkey's language setting, PB v2.5.12 is Traditional Chinese.
Screenshots: ![image](https://i.imgur.com/7ukHYXw.png) ![image](https://i.imgur.com/6HDqmbt.png)

It's strange since my chrome is Traditional Chinese by default. How to check the language interface of PB in AG for Windows? Well, I just found that I could check the language interface of PB by clicking its **Homepage** in AG for Windows. I have checked the language interface of WoT v1.1.9 is Traditional Chinese. BTW, I wish to update their translations. Thanks.
lancelot-moon commented 5 years ago

@northis

  1. Do you have idea why AG PB is Simplified Chinese interface when choosing browser default in the Tampermonkey's language setting? My browser default should be zh-TW. The locale of my Windows 10 is also zh-TW.

(AG PB shows correct language interface according to AG for Windows.)

  1. May you update PB version on greasyfork.org? Thanks. https://greasyfork.org/zh-TW/scripts/33396-adguard-popup-blocker
tvinzz commented 4 years ago

@lancelot-moon, what is your version of Tampermonkey? try to replace zh-TW with zh_TW in userscript and test it.

tvinzz commented 4 years ago

@lancelot-moon

lancelot-moon commented 4 years ago

@tvinzz I don't use Tampermonkey now. Just ma have a bug for browser default in the Tampermonkey's language setting.

tvinzz commented 4 years ago

I tested via Tampermonkey browser extension and Adguard application. Cannot reproduce.