AdguardTeam / PopupBlocker

Popup blocking userscript
GNU Lesser General Public License v3.0
326 stars 30 forks source link

Options are incorrectly displayed when "long link" is blocked #250

Open AdamWr opened 2 years ago

AdamWr commented 2 years ago

Steps to reproduce:

  1. For example, add this rule to user filter:

    example.org#%#AG_onLoad(function() { document.documentElement.addEventListener("click", () => window.open(`/test${"t".repeat(500)}`)) });

    or run this code in console (after step 2):

    document.documentElement.addEventListener("click", () => window.open(`/test${"t".repeat(500)}`))
  2. Go to - https://example.org/

  3. Click somewhere

  4. Popup should be blocked

  5. Click on "Options" button

    Screenshot - some options are not visible

image

It should looks like that:

Screenshot ![image](https://user-images.githubusercontent.com/29142494/134333507-778a7dae-122c-4c10-ac0e-48c6fcc0cc71.png)

AdGuard Popup Blocker (Beta) 2.5.56

ghost commented 4 months ago

I have the same problem as above.

stanislav-atr commented 4 months ago

@NightmareWyrm, hi! This is not reproducible on my side, could you please specify the website and steps to reproduce this?

@AdamWr, could you please confirm that this issue is fixed?

AdamWr commented 4 months ago

Unfortunately, I still can reproduce it with version 2.5.94. As far as I understand, the problem is that the blocked link doesn't fit on the screen, because is too long. If I change repeat(500) to for example repeat(450) (in the script from the first post) then it's fine. @stanislav-atr Could you please try to change it to something like repeat(50000):

document.documentElement.addEventListener("click", () => window.open(`/test${"t".repeat(50000)}`))

and then check again?

ghost commented 4 months ago

@NightmareWyrm, hi! This is not reproducible on my side, could you please specify the website and steps to reproduce this?

Go to this link: https://totalsportek.pro/game/real-madrid-vs-bayern-munchen/26987/ Click above the video player and below the live stream multiple times to trigger popup

image