AdguardTeam / PopupBlocker

Popup blocking userscript
GNU Lesser General Public License v3.0
315 stars 30 forks source link

Auto-updating between versions #273

Closed TPS closed 1 year ago

TPS commented 2 years ago

I think this is some weird standard for userscripts that I never understood (is it meant for security?), but this 1 doesn't update properly, either, presumably because of the version being embedded in the path. Could there be additionally a canonical address (like https://userscripts.adtidy.org/beta/popup-blocker/latest/popupblocker.user.js or https://userscripts.adtidy.org/release/popup-blocker/latest/popupblocker.user.js) that'd actually allow auto-updating to work?

zzebrum commented 1 year ago

reopen if needed

zzebrum commented 1 year ago

wrong issue 🙈

maximtop commented 1 year ago

Actually, there are such links. And you can find them in the readme section of https://github.com/AdguardTeam/PopupBlocker#installation. The userscript would be updated along with the filters. Please feel free to reopen this issue if you have other questions.

TPS commented 1 year ago

@maximtop This seems correct ifF y'all stay @ v2.5.x .… What happens when you change the version or URL convention?

maximtop commented 1 year ago

We would specify a new link in the manifest for updates.

TPS commented 1 year ago

See, that's the point of a canonical link. Just like for the filter lists, a permanent link, irrelevant of version, is useful to avoid having to update settings.

maximtop commented 1 year ago

In case of any changes to the version, we will update the link in the next version of the Popup Blocker, so users won't have to manually update anything.