AdguardTeam / PopupBlocker

Popup blocking userscript
GNU Lesser General Public License v3.0
315 stars 30 forks source link

AdGuard Popup Blocker Beta doesn't work in Firefox #289

Closed AdamWr closed 1 year ago

AdamWr commented 1 year ago

Steps to reproduce:

  1. Install AdGuard Popup Blocker (Beta) version 2.5.85
  2. Open Firefox (in Chrome it works correctly)
  3. Go to - https://example.org/
  4. Run in browser console:
    document.documentElement.addEventListener("click", () => window.open(`/test`) );
  5. Click anywhere

Popup should be blocked, but it looks like that there is an error. This error seems to occurs on any website, so it looks like that there is something wrong with user script in Firefox.

Screenshot ![image](https://user-images.githubusercontent.com/29142494/232225391-9905f744-c4ae-48af-8ea4-d1063959d2d2.png)

Stable version of AdGuard Popup Blocker works fine.

contribucious commented 1 year ago

:eyes: Observed on my side as well.

Indeed, I needed to manually add the stable version in my AG for Windows (nightly) and disable the beta one temporarily. :relaxed:

maximtop commented 1 year ago

Thank you. Did you update to the new beta version manually?

AdamWr commented 1 year ago

AdGuard Popup Blocker Beta is part of the AdGuard for Windows nightly build, so I think that it has been updated automatically.

contribucious commented 1 year ago

For my part, regarding this new beta version 2.5.85, either automatically or … following a Check for filter updates… (which also updates the extensions), used frequently lately (to update in an immediate way my LAN custom filters).

contribucious commented 1 year ago

Manually updated to the new beta version 2.5.86 and … looks like it's indeed fixed. ✔️

Thank you for your quickness! 👍