search

AdguardTeam / PopupBlocker

Popup blocking userscript
GNU Lesser General Public License v3.0
337 stars 31 forks source link

False positive on google.com/analytics #36

Closed ameshkov closed 7 years ago

ameshkov commented 7 years ago

Video: https://uploads.adguard.com/up04_cxpzp.mp4

Open https://www.google.com/analytics/ to reproduce it.

theseanl commented 7 years ago

This was caused by allowing Google Tag Manager on google.com. When auto-event tracking is enabled, on certain circumstances gtm calls window.open inside an event handler attached to document, hence it is considered suspicious. This problem can be more prominent when Popup Blocker is used without adblockers.

In 2.1.6 version, an workaround was implemented to recognize popups caused by gtm and to allow certain popup detection passes for such popups.