search

AdguardTeam / PopupBlocker

Popup blocking userscript
GNU Lesser General Public License v3.0
337 stars 31 forks source link

Whitelisting issue on badoo.com #46

Closed vozersky closed 7 years ago

vozersky commented 7 years ago

STR:

  1. register an account at badoo.com and log in
  2. next window tells you to upload your photos, click on the following icon:

https://uploads.adguard.com/up05_i6z4e.png

  1. Try to whitelist the blocked pop-up

Expected result: The pop-up has beed added to the whitelist. Actual result: Nothing happens.

image

Here's the video:

https://uploads.adguard.com/up05_4axfd.mp4

reported on our forum, reproduced

vozersky commented 7 years ago

@seanl-adg please take a look

theseanl commented 7 years ago

There are 2 distinct issues here, the first one is a whitelisting issue, and the second one is a popup detection false-positive.

The whitelisting issue is caused by the website's CSP policy conflicting with AG's websocket api, and the same issue was reported before https://github.com/AdguardTeam/AdguardForWindows/issues/1961.

The false-positive is caused by the website's own event delegation mechanism, and I don't see a straightforward way to detect it with a generic criteria. I expect users to manually whitelist the website in such cases — maybe I should implement a default whitelist for popular websites.