search

AdguardTeam / PopupBlocker

Popup blocking userscript
GNU Lesser General Public License v3.0
337 stars 31 forks source link

slideshare.net - Mobile view: links blocked #49

Closed danidoedel closed 6 years ago

danidoedel commented 7 years ago

PopupBlocker 2.1.7 AdGuard for Windows 6.2.424.2123

https://www.slideshare.net/

Clicking on any link will result in an error and the link won't open. Normal desktop view of the page works fine.

image

theseanl commented 7 years ago

Thanks for reporting this issue. There are 2 issues: the first is a false-positive, and the second is an error that is shown in the screenshot you've uploaded.

Currently AG Android does not support userscripts, so Popup Blocker wasn't tested a lot on mobile devices, and I expect that we will need some work to make it work reliably on mobile devices.

The console error was caused by a code path that was supposed to be chosen when a popup is attached to touch events.

Regarding the false-postive issue, it is caused by FastClick library that the website uses. It generates an artificial click when user touches somewhere, before the browser generates a click event. Due to its similarities with artificial clicks generated by popup/popunder scripts, it was detected as popups.

Now having this issue at hand, it seems that there are understandable reasons to create and dispatch an artificial events to the same target where the user has originally clicked or touched on, so I will add another check for this, and allow artificial clicks for such cases.