search

AdguardTeam / PopupBlocker

Popup blocking userscript
GNU Lesser General Public License v3.0
337 stars 31 forks source link

Implement alternative popup detection mechanism #5

Closed theseanl closed 7 years ago

theseanl commented 7 years ago

The current method almost does not work in FF, because FF does not support window.event, and retrieving event via Function.caller is not reliable, because it cannot be used in strict mode and can't handle recursions in the call stack. An alternative mechanism will provide much benefit for such cases.

ameshkov commented 7 years ago

Assigned to v2.1. Let's make the very first release compatible with Chrome

ameshkov commented 7 years ago

This time it's due to FF's limitations, it does not provide any viable alternatives so we are forced to use some dangerous tricks in order to make it work with FF.

ameshkov commented 7 years ago

This has nothing to do with the $popup modifier. This repo is about generic approach to block popular popups scripts, so that we didn't even need to craft custom rules.

ameshkov commented 7 years ago

Oh, I don't say we won't provide the FF solution, we'll just do it later as it is more complicated. Before merging that pull request we want to be sure that the simple solution works as it should so that we could use it as a basis and compare the FF solution with it.

ameshkov commented 7 years ago

In case of adguard later is just too much later....

I wouldn't be that pessimistic, the pull request is waiting to be merged.

ameshkov commented 7 years ago

@seanl-adg

  1. The new pop-up blocker causes significant issues with gmail and twitter
  2. Gmail initial load is very slow
  3. Twitter just hangs
theseanl commented 7 years ago

@ameshkov I couldn't reproduce those issues with 2.1.0 dev version