AdguardTeam / PopupBlocker

Popup blocking userscript
GNU Lesser General Public License v3.0
337 stars 31 forks source link

False-positive on disqus.com/embed/ #53

Closed theseanl closed 6 years ago

theseanl commented 6 years ago

Steps to reproduce:

Result: An error is displayed in the devtools console.

We need to wrap every place where we access Function.arguments with try-catch block. Also, we need to include disqus iframe into default exceptions in release versions.

theseanl commented 6 years ago

Fixed in https://github.com/AdguardTeam/PopupBlocker/commit/528cdab513bec9c2e661e0590b500abb5da86ac0.