search

AdguardTeam / PopupBlocker

Popup blocking userscript
GNU Lesser General Public License v3.0
337 stars 31 forks source link

False-positive at blog.naver.com #64

Closed theseanl closed 6 years ago

theseanl commented 6 years ago

Source We have 2 problems here,

  1. False-positive issues used by the website's own event delegation framework https://github.com/naver/jindojs-jindo, which is going to be deprecated.
  2. Alert is not shown, the document.body of the page is a frameset element (which is being deprecated), and it appears that an alert iframe appended to it is not being displayed. I missed the fact that document.body can be a frameset node. MDN states that document.body can be either body or frameset node.
    • In light of the above, there are several places where we use document.body's tag name to determine if a node is body, and such places need to be adjusted to include frameset case if necessary, or otherwise I have to leave a comment on why frameset case is not applicable.
theseanl commented 6 years ago

Fixed in https://github.com/AdguardTeam/PopupBlocker/commit/84fe773e30710d7719e238aa8f461f297a0ae08e