search

AdguardTeam / PopupBlocker

Popup blocking userscript
GNU Lesser General Public License v3.0
337 stars 31 forks source link

tinder.com - false positive #70

Closed danidoedel closed 6 years ago

danidoedel commented 6 years ago

If you click on the Facbook button, the PopupBlocker blocks the log in (https://tinder.com/app/login).

image

image

tinder.com-1514474719499.log

theseanl commented 6 years ago

This is caused by React. It seems that the react detection introduced in https://github.com/AdguardTeam/PopupBlocker/issues/55 is not enough in this case. One way to proceed is using the detection mechanism used by react-devtools browser extension detects react instances.

ameshkov commented 6 years ago

@seanl-adg that'd work

theseanl commented 6 years ago

Fixed by https://github.com/AdguardTeam/PopupBlocker/commit/25a6416315a6513c8b67a976ae9da512de1d8721