search

AdguardTeam / PopupBlocker

Popup blocking userscript
GNU Lesser General Public License v3.0
337 stars 31 forks source link

amanice.ru - authorization through social networks is blocked #94

Closed Alex-302 closed 5 years ago

Alex-302 commented 6 years ago

image

theseanl commented 6 years ago

There are two flaws that are related to this. First is of overlay detection logic - Currently, when retrieving Event object representing user action, the Popup Blocker may retrieve it from ancestor frames, because websites may call open from descendant frames. From the event, we retrieve its target and check whether it looks like an artificial overlay. However, I made a mistake that the size of target element is only compared with the 'current' frame, where the correct way would be to compare it with the frame from where we retrieved the event.

The second is with 'create test' in event timeline, we should add a mutation observer for iframes to prevent some iframes from stay long undetected. Actually I started to feel that this test is intrinsically not very robust. The create test has been important in FF, because some detection logic that relies on parent frame's window.event is unavailable there. We may consider removing it after improving the polyfill.

zzebrum commented 5 years ago

can't repro with AG for win v7.0