search

AdguardTeam / Scriptlets

AdGuard scriptlets library
GNU General Public License v3.0
148 stars 29 forks source link

Add new scriptlet — append/load scripts #196

Closed AdamWr closed 2 years ago

AdamWr commented 2 years ago

Sometimes apps cannot detect source of the request, so we need a scriptlet which we load these scripts, so source will be detected.

For example here - https://github.com/AdguardTeam/AdguardFilters/issues/110659 Source of connatix.com script is not detected, so we cannot easily fix it with apps.

Screenshot ![image](https://user-images.githubusercontent.com/29142494/154472426-20eef12f-3cd7-4ba2-b176-91516b46974b.png)

Another case - https://github.com/AdguardTeam/AdguardFilters/issues/109135 After clicking on "Produkt bewerten" button, mpsnare.iesnare.com/snare.js is loaded and source is not detected.

Screenshot ![image](https://user-images.githubusercontent.com/29142494/154473423-77b7238b-aa3a-45b3-9aec-c7846f685f43.png)
ameshkov commented 2 years ago

Actually, I think this is a wrong place to solve this kind of issues. We're trying to fix CoreLibs bug in Scriptlets which are used in all products.

Here's a better alternative solution: https://github.com/AdguardTeam/CoreLibs/issues/135#issuecomment-1042893336

@AdamWr could you please add similar examples to that CL issue?

AdamWr commented 2 years ago

Unfortunately, currently I don't have any other examples, but if I will find something then I will add it to mentioned issue.