Closed scripthunter7 closed 1 year ago
Interesting! Not sure they'll accept it though, I am seeing many PRs with the "Pending Popularity" label.
Not sure they'll accept it though
@ameshkov You may be right, but I think it's worth a try if you have free capacity. I did a quick search and found that there are a lot of adblock lists on GitHub. The problem with these projects is that they are a bit difficult to count with a search engine because the filter lists are only txt files. Here are some links:
Additionally, these projects are very popular:
Update: According to the documentation below, at least 200 respositories are required to support the new syntax: https://github.com/github/linguist/blob/master/CONTRIBUTING.md#adding-a-language
See:
In most cases we prefer that each new file extension be in use in at least 200 unique
:user/:repo
repositories before supporting them in Linguist.
Unfortunately, there is no unique extension for adblock lists. :confused:
Update 2:
I have collected some links:
Huh, 130 is not bad. We need 70 more.
On a side note, have you been invited to the filter list authors slack channel? It's a bit easier to discuss some things there.
On a side note, have you been invited to the filter list authors slack channel?
@ameshkov No, not yet. I wrote you an email :)
If my calculations are correct (It required some pretty heavy RegEx with https://github.com/collinbarrett/FilterLists/tree/main/services/Directory/data 's database), you can add these 122 repos to the list, putting it well over the 200-project treshold:
@DandelionSprout Thank you! I merged the two lists and filtered out duplicates from the result. @ameshkov
@ameshkov I created the PR
@ameshkov
! Now it is working :)
##.yay
! Yay!
||this-is-really-awesome^$all
@ameshkov Just an idea, but the adblock syntax highlight could be extended to GitHub by including this project in the GitHub Linguist. If I've correctly interpreted the documentation I've read so far, then this would mean that the syntax highlight could work on the following link (for example): https://github.com/AdguardTeam/AdguardFilters/blob/master/EnglishFilter/sections/foreign.txt
Example markdown syntax
This thing could also work in markdown syntax, which is useful for issues / discussions, etc:
Docs