AdguardTeam / VscodeAdblockSyntax

Comprehensive extension to manage Adblock Syntax in VSCode: syntax highlighter, linter and much more. Available on the VSCode Marketplace.
https://marketplace.visualstudio.com/items?itemName=adguard.adblock
MIT License
74 stars 8 forks source link

to=, from= and method= network filter options #58

Closed MasterKia closed 1 year ago

MasterKia commented 1 year ago

@scripthunter7 Hi, there are some new uBlock Origin syntax; I thought I'd let you know.

from= is an alias for domain= and to= is a superset of denyallow=: https://github.com/gorhill/uBlock/commit/19f8b30d577ac17097b8060adfc92093866e26d8

method=: https://github.com/gorhill/uBlock/commit/b6981877ba8f9011292aee9556c4d4c08c1bfd2d

Thanks.

scripthunter7 commented 1 year ago

@MasterKia It seems that the new version has been uploaded to GitHub, but it will take some time before it will work properly everywhere:

||google.com^$method=post|get
||example.com^$method=~get
MasterKia commented 1 year ago

Very nice.

$script,3p,from=example1.com|example2.com,to=example3.com|~example4.com,method=~get|post
MasterKia commented 1 year ago

@scripthunter7 New syntax ("call-nothrow" and "ext_devbuild"):

example.com##+js(call-nothrow, Object.defineProperty)
!#if ext_devbuild
example.com##.ads
!#endif

https://github.com/gorhill/uBlock/commit/e93117cbb607472a830e1c0653dfbddde4c965fc

https://github.com/gorhill/uBlock/commit/464b54bbc6432fa07c85820b37f72b77f0855638 Should I open another issue?

scripthunter7 commented 1 year ago

Should I open another issue?

@MasterKia I think it's a good idea because it's a bit different topic and it's easier to manage that way. Thanks!

Anyway, these changes also affect the VSCode plugin, so I think the [GitHub Linguist] prefix is unnecessary here.

EDIT: I created a separate issue for it:)

MasterKia commented 1 year ago

@scripthunter7 There seems to be a mis-highlighting regarding $strict3p/$strict1p:

||example.com^$xhr,strict3p,strict1p

The "strict" part is not highlighted, is that by design?

scripthunter7 commented 1 year ago

@MasterKia This seems to be a bug, please open a separate issue for this

MasterKia commented 1 year ago

Done. https://github.com/ameshkov/VscodeAdblockSyntax/issues/69