search

AdguardTeam / adguardcert

Magisk module that allows using AdGuard's HTTPS filtering for all apps
https://adguard.com/
MIT License
336 stars 22 forks source link

Not compatible with kernelsu #42

Closed uaevuon closed 12 months ago

uaevuon commented 1 year ago

Will it support kernelsu?

I just came back to magisk cause this module does not do anything on kernelsu.

XAlboX commented 1 year ago

It needs Zygisk to work. https://github.com/Dr-TSNG/ZygiskOnKernelSU

uaevuon commented 1 year ago

It needs Zygisk to work. https://github.com/Dr-TSNG/ZygiskOnKernelSU

Latest 2.0 beta versions do not require zygisk.

Rtizer-9 commented 1 year ago

The latest 2.0 beta 4 doesn't need either zygisk or riru to work and is completely compatible with ksu but it needs ag version 4.2 something nightlies to work.

You need to go into settings > filtering> network> https filtering> security certificate and install both the certificates including the secondary one (yes there are two certificates in latest nightlies, I too missed it at first) and then flash latest beta zip of this module in ksu and then reboot.

uaevuon commented 1 year ago

The latest 2.0 beta 4 doesn't need either zygisk or riru to work and is completely compatible with ksu but it needs ag version 4.2 something nightlies to work.

You need to go into settings > filtering> network> https filtering> security certificate and install both the certificates including the secondary one (yes there are two certificates in latest nightlies, I too missed it at first) and then flash latest beta zip of this module in ksu and then reboot.

I am on stable 4.1. Guess that's the reason.

uaevuon commented 1 year ago

Screenshot_20230827-021712_Play_Integrity_API_Checker On latest nightly(v4.2.56), I guess it really is not compatible. Installed two certs, but the module do not move the cert to system properly. It does not appear on settings app and make this error on some apps. The screenshot is from this app.

Rtizer-9 commented 1 year ago

The order of doing things is of importance here.

You first need to give ag root permissions manually using ksu and then only the secondary/intermediate certificate menu will appear in the location I mentioned above.

Now after this only you'll be able to install that intermediate certificate.

When the installation is done it'll show that both the certificates are installed but upper one can be moved to system.

AFTER this, manually go to ksu and then flash the module zip and reboot.

I personally checked it on v4.2.56 nightly with the app you mentioned above.

Do remember that some apps with very heavy security employing things like SSL pinning do not allow users to anyhow analyse the traffic of their application which includes having an app like ag in your phone which lets you see the requests, so they'll still not work even with all this setup in most cases.

The above setup will still work with almost all apps because the certificate is in the system store.

PS : Always remember, first certificates are installed and then module flashing should happen because only then during the flashing it'll find a user cert which it copies into the system store. And you need to flash the module over the previous module in this order only, the key point is the certificate should already be already before flashing happens.

uaevuon commented 1 year ago

I did same thing on Magisk canary and it works. ssl errors do not appear on magisk installed device. The only difference here is kernelsu vs magisk. If it worked on your side, I have no idea why this kernelsu issue happens on my device only.

Rtizer-9 commented 1 year ago

I would suggest starting from a fresh state.

Take Adguard settings backup and then uninstall everything including ag and the module and then reboot.

Install ag now and give root permissions, then install both the certificates and import settings from backup and after all this when ag certificate show both the certificates have been installed properly and is asking for moving the cert into system then install the Module in ksu and reboot. Everything should work fine now.

If you have 2-3 certificates in the user store from leftovers then I'd suggest removing all of them too during uninstallation of ag.

uaevuon commented 12 months ago

Finally find out the solution. I have to set those app in kernelsu as custom template and turn off the option.

harkirtancr7 commented 7 months ago

how did you get that to work? mine still has same problem till date

XAlboX commented 7 months ago

how did you get that to work? mine still has same problem till date

Try disabling "unmount modules by default" in KSU. This could make root permissions visible for some apps like banking ones, in those apps you should set a custom profile and enable the unmount modules option to hide modules (Root(?)) Let me know 🤔