AdguardTeam / adguardcert

Magisk module that allows using AdGuard's HTTPS filtering for all apps
https://adguard.com/
MIT License
281 stars 18 forks source link

Consider new base-module & matched cert encoding #9

Open 28Black opened 2 years ago

28Black commented 2 years ago

Your module appears to have been created from a deprecated module. Consider forking its module's fork [here] (https://github.com/Androidacy/movecerts) to make sure it remains compatible with newer versions of Magisk and Android. In addition, you just move the cert and rename it with the cert hash. It might be a good idea to convert your DER encoded cert to PEM encoding like all other certs stored in the system store are.

Eg via openssl - I used to do the following to do this and rename the certificate correctly. $ openssl x509 -inform DER -outform PEM -in adguard.crt -out adguard.crt $ openssl x509 -noout -text -fingerprint -in adguard.crt >> adguard.crt $ mv -v adguard.crt "$(openssl x509 -subject_hash_old -noout -in adguard.crt)".0