search

AdguardTeam / cname-trackers

This repository contains a list of popular CNAME trackers
https://adguard.com/
MIT License
387 stars 37 forks source link

apply for https://ads.shopee.sg/ #40

Closed COOKIES-LGL closed 2 years ago

COOKIES-LGL commented 2 years ago

"https://ads.shopee.com.br/", "https://ads.shopee.tw/", "https://ads.shopee.sg/", "https://ads.shopee.com.my/", "https://ads.shopee.vn/", "https://ads.shopee.co.th/", "https://ads.shopee.ph/", "https://ads.shopee.cn/", "https://ads.shopee.kr/", "https://ads.shopee.com.mx/

Above lists our affected sites, Our site will be intercepted by the $popup rules While we can open our sites by in the address bar, we cannot open them through new windows, especially for AdGuard interceptors.

The sites above are actually block, and although we use the CDN to record the static resources, we still can't use the site properly

截屏2022-04-13 下午5 12 48

OS/version: mac Browser/version: Chrome: version 98 Adblock Extension/version: AdGuard: version 4.0.141

I really hope that you can reply to us I wish you a happy work

ameshkov commented 2 years ago

@AdguardTeam/filters-maintainers ://ads.$popup seems to be an overkill, isn't it?

AdamWr commented 2 years ago

Okay, I have removed this rule.

COOKIES-LGL commented 2 years ago

First of all, thank you for your reply. When will the rules come into effect? I have also mentioned PR to eastlist before, but it was not adopted, What is the way to submit changes to easylist? Looking forward to your answer @AdamWr

AdamWr commented 2 years ago

When will the rules come into effect?

Filters update should be available now, please update filters in settings in AdGuard extension.

I have also mentioned PR to eastlist before, but it was not adopted, What is the way to submit changes to easylist?

You can report it here - https://github.com/easylist/easylist/issues

COOKIES-LGL commented 2 years ago

hi @AdamWr thanks for your reply

and tomorrow i have made a PR for easylist and have been merged .

but No update was made on the rules

截屏2022-04-15 下午12 15 16

截屏2022-04-15 下午12 14 58

When will the rules come into effect?

Looking forward to your answer

AdamWr commented 2 years ago

In theory it should be available after about 1-2 hours after pull request has been merged, but it seems that it's not yet. I guess that these changes should be available in a few hours.

AdamWr commented 2 years ago

It seems that I was wrong and update was available, but it looks like that ~ads.shopee.com.br (I have checked this website) has not been added to exception here - https://github.com/easylist/easylist/commit/1fd56ea53d54aaaf820ccea911f6cfc8ff642ad4

COOKIES-LGL commented 2 years ago

OH, @AdamWr Thanks so much for your reminder, I submitted the PR again.

11680