AdguardTeam / cname-trackers

This repository contains a list of popular CNAME trackers
https://adguard.com/
MIT License
387 stars 37 forks source link

Incorrect RZP format #73

Closed ghost closed 1 year ago

ghost commented 1 year ago

In order to be standard RPZ format we need to include proper header into the file. This will allow certain program to properly detect if downlaod file is rpz file. Havining only CNAME . string is not enough to be standard rpz file. eg:

$TTL 6h @ IN SOA AdguardTeam.local. (741328541 6h 1h 1w 2h) IN NS localhost.

slavaleleka commented 1 year ago

what file are you talking about? what exactly do you suggest?

ghost commented 1 year ago

This file (https://github.com/AdguardTeam/cname-trackers/blob/master/combined_disguised_ads_rpz.txt) is supposed to be rpz file. But it is not a standard rpz format. It needs proper file header. Simply insert what I suggested as first 3 lines in the file.

Alex-302 commented 1 year ago

@jellizaveta Description is in https://www.isc.org/docs/BIND_RPZ.pdf #3

Example with comments ``` $TTL 300 @ IN SOA localhost. need.to.know.only. ( 201702121 ; Serial number 60 ; Refresh every minute 60 ; Retry every minute 432000 ; Expire in 5 days 60 ) ; negative caching ttl 1 minute IN NS LOCALHOST. deteque.com IN CNAME rpz-passthru. *.deteque.com IN CNAME rpz-passthru. spamhaus.org IN CNAME rpz-passthru. *.spamhaus.org IN CNAME rpz-passthru. 32.25.195.194.32.rpz-ip IN CNAME rpz-passthru. ; whitelist 34.194.195.25/32 32.71.219.156.35.rpz-ip IN CNAME rpz-passthru. ; whitelist 35.156.219.71/32 example.com IN CNAME . ; local block against example.com *.example.com IN CNAME . ; local block against example.com ```
jellizaveta commented 1 year ago

@markster17 Could you provide a little more information about the usage problem? In which program are you using the rpz file format, maybe some steps to reproduce, file reading errors or something like that

ghost commented 1 year ago

That is a wrong question. It’s not about usage but standard itself. Do you want to publish this file as Rpz?

It looks as if you started with the “usage” and then adopted the file. If you want to be completely compliant with standard than you need proper header in the file.

Alex-302 commented 1 year ago

@markster17 But user can use own parameters, just merge a file with header with downloaded file (not by hand, of course).