AdguardTeam / companiesdb

This is a companies DB that we use in AdGuard Home and AdGuard DNS.
Creative Commons Attribution Share Alike 4.0 International
26 stars 13 forks source link

Improve documentation for what will be accepted into the database, and other best practices #242

Open ghost opened 1 year ago

ghost commented 1 year ago

Many times I have had pull requests denied due reasons not documented in this repo. This is not so much an issue for me, other than being a slight annoyance, but more-so for the AdGuard employees who continuously have to request corrections for research and information I could have provided if better documented.

Due to the lack of documentation, my understanding of this repo has been to add active companies and/or active trackers I find in my query logs that are not already in the companiesdb database. This has proven not to be the case (see the rejected pr's).

It would be good if this was avoidable by clearly documenting what is acceptable and what is not acceptable when adding new companies and trackers.

Below is a non-exhaustive list of issues I have run into when awaiting pull request approval: