search

AdguardTeam / companiesdb

This is a companies DB that we use in AdGuard Home and AdGuard DNS.
Creative Commons Attribution Share Alike 4.0 International
26 stars 13 forks source link

Add Alphabet Inc. #263

Closed ghost closed 1 year ago

ghost commented 1 year ago
ghost commented 1 year ago

@Alex-302 most of the trackers that were added came from dist/trackers, many of which are obsolete. My concern is that as much of that obsolete data is linked to Google, and if this pr gets approved, we'll have trackers linking back to both Google and Alphabet, coexisting in the same database.

For example, DoubleClick was merged with Google's ad tracking platform to create Google Marketing Platform, thus making all DoubleClick entries obsolete. Not having any data on whether the doubleclick domains are still active though, I don't know the correct course of action here to prevent conflicts in the database.

Should they simply be removed from source/trackers and ignored in dist/trackers?

Alex-302 commented 1 year ago

Should they simply be removed from source/trackers and ignored in dist/trackers?

I'd prefer to remove obsolete trackers, if they replaced/dead/merged with others. But this change must be tested by local build.

ghost commented 1 year ago

Should they simply be removed from source/trackers and ignored in dist/trackers?

I'd prefer to remove obsolete trackers, if they replaced/dead/merged with others. But this change must be tested by local build.

Understood. The issue is that all Google entries in dist/trackers are reliant on Google being in source/companies.

Example Removing the obsolete admeld from source/trackers, will cause the admeld in dist/trackers to look for the companyID Google in dist/companies. It won't find it there as it will have been removed and replaced with Alphabet, which will an error when building locally.

[4:31:53 pm] ERROR Error while building the companies DB: Error: Tracker admeld has an invalid company ID: google

The README doesn't mention how to remove obsolete data from dist/trackers, but does reference using the value null if it doesn't exist.

Warning

If the value does not exist - enter null:

This would create a large amount of obsolete nulled entries in source/trackers though.

What would you recommend be the course of action here?

ghost commented 1 year ago

Moving changes to a new fork. Existing fork refused to sync any changes within the last 2 months.