AdguardTeam / companiesdb

This is a companies DB that we use in AdGuard Home and AdGuard DNS.
Creative Commons Attribution Share Alike 4.0 International
26 stars 13 forks source link

Fix lexicographic ordering of trackerDomains #280

Closed ghost closed 11 months ago

ghost commented 11 months ago

This pr sorts the source trackerDomains lexicographically, as is used by TypeScript/JavaScript.

jellizaveta commented 11 months ago

we sort domains alphabetically by value, to make it visually easier to see all domains of one tracker

ghost commented 11 months ago

Alphabetical only takes into consideration strings of letters, not numbers.

Lexicographical takes into consideration other characters as well.

For the purpose of this list, alphabetical and lexicographical are the same thing. The output is the same.

Alex-302 commented 11 months ago

Conflicts:(

ghost commented 11 months ago

To be cleanly fixed in a future pr.