search

AdguardTeam / dnsproxy

Simple DNS proxy with DoH, DoT, DoQ and DNSCrypt support
Apache License 2.0
2.37k stars 246 forks source link

Would you like to hide DoH http user-agent header? #211

Closed PeterDaveHello closed 2 years ago

PeterDaveHello commented 2 years ago

Currently, the user-agent header that will be sent when using DoH is Go-http-client/2.0, though we know that there're many profiling mechanisms to find out the tools and details about the users, but maybe it'll be great if we can give one less information, like user-agent string.

That's what are Firefox and iOS doing, both known as privacy-protected products, not sure if this is this something dnsproxy would like to do? I've prepared a patch that can be submitted as a pull request if it'll be accepted here ;) What do you think?

ameshkov commented 2 years ago

Tbh, I agree and I think that the proper approach would be to not send user-agent header at all, just like Mozilla does: https://bugzilla.mozilla.org/show_bug.cgi?id=1543201

If you have a patch ready, please submit a pull request.

Thank you!

PeterDaveHello commented 2 years ago

PR sent in https://github.com/AdguardTeam/dnsproxy/pull/212, thanks @ameshkov!