search

AdguardTeam / golibs

Small helper Go libraries
The Unlicense
18 stars 9 forks source link

make SafeWrite actually safe #2

Closed Snawoot closed 4 years ago

Snawoot commented 4 years ago
codecov-io commented 4 years ago

Codecov Report

Merging #2 into master will decrease coverage by 4.41%. The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
- Coverage   86.61%   82.20%   -4.42%     
==========================================
  Files           5        6       +1     
  Lines         142      163      +21     
==========================================
+ Hits          123      134      +11     
- Misses         13       18       +5     
- Partials        6       11       +5
Impacted Files Coverage Δ
file/file.go 52.38% <57.14%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 071a536...27d04bc. Read the comment docs.

Snawoot commented 4 years ago

Addressed requested changes and also added tests

ameshkov commented 4 years ago

Merged, thank you for the contribution!

https://github.com/AdguardTeam/golibs/commit/49bb70664571807b6ffb635df208e5416ba10c7e