search

AdguardTeam / tsurlfilter

AdGuard content blocking library
GNU General Public License v3.0
50 stars 13 forks source link

The strict-blocking page shown by "$document", does not show which list that contains the trigger rule #35

Open DandelionSprout opened 2 years ago

DandelionSprout commented 2 years ago

While I applaud the addition of $document warnings in AdGuard products that were added a year-ish ago, there is one significant problem: It doesn't show which list that contains the rule that cause the warnings to appear.

Here's for instance from AdGuard for Android: image

And from AdGuard Browser Extension in Vivaldi: image

This causes delays in debugging, and also make end-users more likely to think it's AdGuard itself that causes the warning.

In comparison, this is how uBlock Origin does it, which adds list info (in this case My filters), as well as a "Disable strict blocking permanently" option to add a whitelisting to the user rules: image

I therefore think AdGuard should at least add list info to its warning pages.

iam-py-test commented 2 years ago

I definitionally support this If something like that is added, I feel that AdGuard should implement something like https://github.com/uBlockOrigin/uBlock-issues/issues/1195, because, as the maintainer of a antimalware list, it would be nice to give more information about why something was blocked (scam, PUP, ransomware, etc) as to help the user make informed choices and also spot false positives (i.e if the user knows I think its ransomware, it is easier to prove it is not, rather than just "malicious")