AdguardTeam / tsurlfilter

AdGuard content blocking library
GNU General Public License v3.0
56 stars 12 forks source link

Support for uBO regexp domain list #89

Open scripthunter7 opened 1 year ago

scripthunter7 commented 1 year ago

uBo implemented regex, if someone trust something like:

/bad-js.$domain=/[a-z-]{18}\.[\w]{2,20}/
/[a-z-]{18}\.[\w]{2,20}/##.bad-class
!
! regex in the dumb version - rather, the webmaster fell how to avoid falling into a safe regex.

but fail for , in cosmetic/scriptlet filters and | in network filters if gorhill rejected repair:

https://github.com/uBlockOrigin/uBlock-issues/discussions/2234#discussioncomment-5403472


In theory, network filtering can be unprotected by domain=/from= and cosmetic filtering can be based on the site's permanent DOM tree (No match to 99% of the rest of the sites on the Internet).

The scriptlet is also still possible to run all over the Internet in uBo, but there have been considerations for years whether to secure this with a minimum of "I am an advanced user" activation.


Also voe is covered sometimes: https://github.com/uBlockOrigin/uAssets/commit/5a660a989b0e836e47bb4886b9a28bf19136783a

(Unfortunately, I don't see how to turn these 36 domains into which regex - The site appears to have no fixed pattern (diffrent words, number order).)

Originally posted by @krystian3w in https://github.com/AdguardTeam/CoreLibs/issues/1550#issuecomment-1553743192

scripthunter7 commented 1 year ago

@maximtop We should move this to AGTree

maximtop commented 1 year ago

@maximtop We should move this to AGTree

ok, lets move

krystian3w commented 1 year ago

Via ZenHub, native "transfer issue" or manually by copy few sentences from here?

image