github-actions[bot]
commented
2 years ago PSScriptAnalyzer results:
:stop_sign: [0] Errors, :warning: [20] Warnings, :information_source: [1] Information
``` RuleName : PSReviewUnusedParameter Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 3211 Message : The parameter 'MessageClass' has been declared but not used. RuleName : PSUseDeclaredVarsMoreThanAssignments Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 772 Message : The variable 'userClass' is assigned but never used. RuleName : PSUseDeclaredVarsMoreThanAssignments Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 788 Message : The variable 'sysUserHasPrefRelClass' is assigned but never used. RuleName : PSUseDeclaredVarsMoreThanAssignments Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 4902 Message : The variable 'isVerifiedSig' is assigned but never used. RuleName : PSUseDeclaredVarsMoreThanAssignments Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 2562 Message : The variable 'isMember' is assigned but never used. RuleName : PSUseDeclaredVarsMoreThanAssignments Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 4211 Message : The variable 'alias' is assigned but never used. RuleName : PSUseShouldProcessForStateChangingFunctions Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 192 Message : Function 'New-SMEXCOEvent' has verb that could change system state. Therefore, the function has to support 'ShouldProcess'. RuleName : PSUseShouldProcessForStateChangingFunctions Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 883 Message : Function 'New-WorkItem' has verb that could change system state. Th erefore, the function has to support 'ShouldProcess'. RuleName : PSUseShouldProcessForStateChangingFunctions Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 1464 Message : Function 'Update-WorkItem' has verb that could change system state. Therefore, the function has to support 'ShouldProcess'. RuleName : PSUseShouldProcessForStateChangingFunctions Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 2634 Message : Function 'Set-AssignedToPerSupportGroup' has verb that could change system state. Therefore, the function has to support 'ShouldProces s'. RuleName : PSUseShouldProcessForStateChangingFunctions Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 2713 Message : Function 'New-CMDBUser' has verb that could change system state. Th erefore, the function has to support 'ShouldProcess'. RuleName : PSUseShouldProcessForStateChangingFunctions Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 3112 Message : Function 'Remove-CiresonWatchListUser' has verb that could change s ystem state. Therefore, the function has to support 'ShouldProcess' . RuleName : PSUseShouldProcessForStateChangingFunctions Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 3146 Message : Function 'Set-WorkItemScheduledTime' has verb that could change sys tem state. Therefore, the function has to support 'ShouldProcess'. RuleName : PSUseShouldProcessForStateChangingFunctions Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 3596 Message : Function 'Set-CoreSCSMAnnouncement' has verb that could change syst em state. Therefore, the function has to support 'ShouldProcess'. RuleName : PSUseShouldProcessForStateChangingFunctions Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 3661 Message : Function 'Set-CiresonPortalAnnouncement' has verb that could change system state. Therefore, the function has to support 'ShouldProces s'. RuleName : PSUseShouldProcessForStateChangingFunctions Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 4171 Message : Function 'Update-SCSMPropertyCollection' has verb that could change system state. Therefore, the function has to support 'ShouldProces s'. RuleName : PSUseShouldProcessForStateChangingFunctions Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 4204 Message : Function 'Set-SCSMTemplate' has verb that could change system state . Therefore, the function has to support 'ShouldProcess'. RuleName : PSUseShouldProcessForStateChangingFunctions Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 4223 Message : Function 'Remove-PII' has verb that could change system state. Ther efore, the function has to support 'ShouldProcess'. RuleName : PSUseUsingScopeModifierInNewRunspaces Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 4287 Message : The variable '$appName' is not declared within this ScriptBlock, an d is missing the 'Using:' scope modifier. RuleName : PSUseUsingScopeModifierInNewRunspaces Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 4311 Message : The variable '$unhealthySCOMApp' is not declared within this Script Block, and is missing the 'Using:' scope modifier. RuleName : PSUseOutputTypeCorrectly Severity : Information ScriptName : smletsExchangeConnector.ps1 Line : 3057 Message : The cmdlet 'Get-CiresonSuggestionURL' returns an object of type 'Sy stem.Object[]' but this type is not declared in the OutputType attr ibute. ```
AdhocAdam
Features
Changes/Enhancements
Follows PowerShell best practices per PSScriptAnalyzer
A few functions have been refactored:
The selected AD Group to retrieve SCOM Distributed Application Health and/or an AD Group to make SCSM Announcements no longer uses a Label to show its Display Name.
The Templates pane in Settings uses the SCSM Template icon instead of the previous Exchange/PowerShell icon
The Logging pane in Settings uses the Windows Event Log icon
In some environments SMLets isn't imported correctly when the PowerShell starts so that section has been moved further up in the connector's execution.
Logging is more representative of start, process, and finish stages of the connector
More logging is provided around retrieving OAuth tokens when using 365
The DisplayName property for Incidents, Service Requests, Problems, and Change Requests are now set as though the Work Item was created in the SCSM console so as to respect the console's search
Bugs
To do: