function best practices

[AdhocAdam]

Standardizing functions used through the connector for consistency and to follow best practice as defined by PSScriptAnalzyer.

• Use dedicated parameter block for all functions
• Functions have verb that could change state, therefore, the function has to support 'ShouldProcess'. As a result, functions updated with this now support the PowerShell -WhatIf switch
• The cmdlet 'Get-CiresonSuggestionURL' returns an object of type ' System.Object []' but this type is not declared in the OutputType attribute.
• PSScriptAnalyzer does not capture parameter usage within a [scriptblock] causing a false positive

[github-actions[bot]]

PSScriptAnalyzer results:

:stop_sign: [0] Errors, :warning: [3] Warnings, :information_source: [0] Information

``` RuleName : PSReviewUnusedParameter Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 2619 Message : The parameter 'UserSamAccountName' has been declared but not used. RuleName : PSReviewUnusedParameter Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 2622 Message : The parameter 'TierId' has been declared but not used. RuleName : PSReviewUnusedParameter Severity : Warning ScriptName : smletsExchangeConnector.ps1 Line : 3441 Message : The parameter 'MessageClass' has been declared but not used. ```

[github-actions[bot]]

PSScriptAnalyzer results:

:stop_sign: [0] Errors, :warning: [0] Warnings, :information_source: [0] Information

``` ```