AdhocAdam
commented
1 year ago Two things:
- I tried updating your branch/fork with a new branch I created called "dev-5.x" that is essentially the current production deployed connector for 5.0.3. While it looks like this still includes a lot of commits since your initial fork/sync, the one thing I noticed is you have a $startTime variable. I assume this is carry over from some commit (I don't know where) and wasn't intentional on your part?
- I've encountered what you're proposing in this pull request I want to say, less than 5 times in the history of the connector. Which is to say, it's never happened enough or with any pattern that I could identify how the connector creates a User gets without a Notification Channel and/or fails to create the related Notification Channel. In any case, I don't think I'm opposed to what you're proposing. I've just been spending time thinking about if there is some danger in doing this I'm/we're not possibly seeing.
alexaxb
Describe the change
Provide an explanation of the changes being made and why you want to make them New-CMDBUser is called when an e-mail address cannot be found in SCSM, but if the username/domain combo already exists in SCSM but without the mail address the user creation will fail without an error message. This has happened to me a couple of times now, and is kind of hard to detect. Added a simple check to see if the user object already exists before creation, and if the creation should fail for some reason, it will be logged as an error.